• clemensh's avatar
    Clarify the order of frame summaries and rename getters · 453a1df2
    clemensh authored
    Document that frame summaries are bottom-to-top, i.e. caller before
    callee, rename FrameSummary::GetFirst to FrameSummary::GetBottom and
    introduce FrameSummary::GetTop.
    For debugged JavaScript frames, it does not really matter which of the
    functions we call, so I replaced a few GetFirst by GetTop instead of
    GetBottom because it matches the semantics more closely.
    
    This CL also reverts part of http://crrev.com/2621953002 by changing
    BreakLocation::FromFrame back to accept a DebugInfo and a
    JavaScriptFrame. We don't plan to create BreakLocations for wasm.
    
    R=yangguo@chromium.org
    BUG=v8:5822
    
    Review-Url: https://codereview.chromium.org/2647433002
    Cr-Commit-Position: refs/heads/master@{#42505}
    453a1df2
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...