• littledan's avatar
    Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++... · 4530f0dc
    littledan authored
    Revert of [typedarrays] move %TypedArray%.prototype.copyWithin to C++ (patchset #6 id:100001 of https://codereview.chromium.org/2671233002/ )
    
    Reason for revert:
    Due to security issue described in review thread.
    
    Original issue's description:
    > [typedarrays] move %TypedArray%.prototype.copyWithin to C++
    >
    > - Removes shared InnerArrayCopyWithin JS builtin from src/js/array.js
    > - Implements %TypedArray%.prototype.copyWithin as a C++ builtin, which
    > relies on std::memmove rather than accessing individual eleements.
    > - Fixes the case where copyWithin is invoked on a TypedArray with a
    > detached buffer.
    > - Add tests to ensure that +/-Infinity (for all 3 parameters) is handled correctly by the
    > algorithm
    >
    > The C++ version gets through the benchmark more than 25000 times as
    > quickly as the JS implementation.
    >
    > BUG=v8:5925, v8:5929, v8:4648
    > R=cbruni@chromium.org, adamk@chromium.org, littledan@chromium.org
    >
    > Review-Url: https://codereview.chromium.org/2671233002
    > Cr-Commit-Position: refs/heads/master@{#42975}
    > Committed: https://chromium.googlesource.com/v8/v8/+/0f1c626d556cbf84b0e572635eb803729f88cbb3
    
    TBR=cbruni@chromium.org,adamk@chromium.org,bmeurer@chromium.org,cwhan.tunz@gmail.com,caitp@igalia.com
    # Not skipping CQ checks because original CL landed more than 1 days ago.
    BUG=v8:5925, v8:5929, v8:4648
    
    Review-Url: https://codereview.chromium.org/2693753002
    Cr-Commit-Position: refs/heads/master@{#43132}
    4530f0dc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...