• Tobias Tebbi's avatar
    [turbofan] extend type asserts to cover all JS types · 45227ffd
    Tobias Tebbi authored
    Extend type assertions to all types covering JavaScript values.
    This is achieved by allocating type representations on the heap using
    newly defined HeapObject subclasses. To allocate these in the compiler,
    we disable concurrent compilation for the --assert-types flag for now.
    
    Fix two type errors that came up with the existing tests:
    1. JSCreateKeyValueArray has type Array (i.e., a JSArray) instead of
       OtherObject.
    2. OperationTyper::NumberToString(Type) can type the result as the
       HeapConstant Factory::zero_string(). However, NumberToString does
       not always produce this string. To avoid regressions, the CL keeps
       the HeapConstant type and changes the runtime and builtin code to
       always produce the canonical "0" string.
    
    A few tests were failing because they check for truncations to work
    and prevent deoptimization. However, AssertType nodes destroy all
    truncations (which is by design), so these tests are incompatible
    and now disabled for the assert_types variant.
    
    Drive-by fix: a few minor Torque issues that came up.
    
    Change-Id: If03b7851f7e6803a2f69edead4fa91231998f764
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234717Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77565}
    45227ffd
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
security Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...