• Benedikt Meurer's avatar
    [inspector] Decouple Console domain from stack trace capturing. · 451a101b
    Benedikt Meurer authored
    The `Console` domain has been deprecated (in favor of `Log` and
    `Runtime`) since over four years now, and its use is strongly
    discouraged.
    
    However, making `Runtime.setMaxCallStackSizeToCapture` useful (in
    light of the refactorings for crbug.com/1283162) and more correct
    (wrt. to the anticipated behavior), would be complicated seriously
    if we also need to worry about `Console` domain interference.
    
    So this CL simply removes the feature that `Console.enable` turns
    on stack trace capturing for error and message objects, and won't
    send `line`, `column`, and `url` with `Console.Message` events
    if they aren't present on the `v8_inspector::V8ConsoleMessage`
    instance (these fields have always been optional anyways).
    
    Bug: chromium:1283162
    Change-Id: I78bd1e040fe15a2372639c403bfc2f4579fd4d0c
    Doc: https://bit.ly/v8-cheaper-inspector-stack-traces
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3361837
    Auto-Submit: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Yang Guo <yangguo@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#78454}
    451a101b
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...