• Clemens Backes's avatar
    [inspector][fuzzer] Fix termination · 4510401d
    Clemens Backes authored
    Joining the thread from the watchdog is problematic, since e.g.
    {pthread_join} (the implementation of {Thread::Join} on POSIX systems)
    has undefined behaviour if multiple threads try to join at the same
    time. In practice, this leads to deadlocks.
    
    Thus implement termination by just calling {TaskRunner::Terminate}, but
    not {TaskRunner::Join}. This fixes the deadlocks in the inspector
    fuzzer.
    The inspector test binary is fixed simarly, even though there it seems
    to not cause problems so far.
    
    In both files, the {Terminate} function is inlined into callers because
    it's only a single line now, with one to two users.
    
    Also, replace the single fuzzer test (which is invalid javascript) by
    two tests: One called "invalid" explicitly, still with invalid
    javascript, and one empty file, which is valid input. That one
    reproduced the deadlock.
    
    R=szuend@chromium.org
    
    Bug: chromium:1142437
    Change-Id: I8fb98b0cdbf3ceff6af6849397e5da5a4e9acd3c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526384Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71054}
    4510401d
Name
Last commit
Last update
..
inspector Loading commit data...
json Loading commit data...
multi_return Loading commit data...
parser Loading commit data...
regexp Loading commit data...
regexp_builtins Loading commit data...
wasm Loading commit data...
wasm_async Loading commit data...
wasm_code Loading commit data...
wasm_compile Loading commit data...
BUILD.gn Loading commit data...
DEPS Loading commit data...
README.md Loading commit data...
fuzzer-support.cc Loading commit data...
fuzzer-support.h Loading commit data...
fuzzer.cc Loading commit data...
fuzzer.status Loading commit data...
inspector-fuzzer.cc Loading commit data...
json.cc Loading commit data...
multi-return.cc Loading commit data...
parser.cc Loading commit data...
regexp-builtins.cc Loading commit data...
regexp.cc Loading commit data...
testcfg.py Loading commit data...
wasm-async.cc Loading commit data...
wasm-code.cc Loading commit data...
wasm-compile.cc Loading commit data...
wasm-fuzzer-common.cc Loading commit data...
wasm-fuzzer-common.h Loading commit data...
wasm.cc Loading commit data...
wasm_corpus.tar.gz.sha1 Loading commit data...