• Clemens Backes's avatar
    [inspector][fuzzer] Fix termination · 4510401d
    Clemens Backes authored
    Joining the thread from the watchdog is problematic, since e.g.
    {pthread_join} (the implementation of {Thread::Join} on POSIX systems)
    has undefined behaviour if multiple threads try to join at the same
    time. In practice, this leads to deadlocks.
    
    Thus implement termination by just calling {TaskRunner::Terminate}, but
    not {TaskRunner::Join}. This fixes the deadlocks in the inspector
    fuzzer.
    The inspector test binary is fixed simarly, even though there it seems
    to not cause problems so far.
    
    In both files, the {Terminate} function is inlined into callers because
    it's only a single line now, with one to two users.
    
    Also, replace the single fuzzer test (which is invalid javascript) by
    two tests: One called "invalid" explicitly, still with invalid
    javascript, and one empty file, which is valid input. That one
    reproduced the deadlock.
    
    R=szuend@chromium.org
    
    Bug: chromium:1142437
    Change-Id: I8fb98b0cdbf3ceff6af6849397e5da5a4e9acd3c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2526384Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#71054}
    4510401d
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...