• Camillo Bruni's avatar
    Reland "[runtime] Use Isolate::ThrowAt with MessageLocation" · 447915ef
    Camillo Bruni authored
    This is a reland of eb6b4ce1
    
    Skip test that serializes Error which references a Script. All errors
    created by ThrowAt store the current Script under the
    error_script_symbol.
    
    Original change's description:
    > [runtime] Use Isolate::ThrowAt with MessageLocation
    >
    > Fix various missing source positions when reporting parse and compile
    > errors. Namely this fixes missing source positions when having invalid
    > module imports.
    >
    > - Use Isolate::ThrowAt with valid MessageLocation objects
    > - Change public Isolate::Throw to no longer accept MessageLocation to
    >   avoid misues
    > - Introduce private Isolate::ThrowInternal that accepts MessageLocation
    >
    > Bug: v8:6513
    > Change-Id: I3ee633c9fff8c9d361bddb37f56e28a50c280ec1
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2467839
    > Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Marja Hölttä <marja@chromium.org>
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#70623}
    
    Bug: v8:6513
    Change-Id: Icba74f74178e28fbda0fd0c237eeb7bacbc33570
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2487123Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Reviewed-by: 's avatarMarja Hölttä <marja@chromium.org>
    Commit-Queue: Camillo Bruni <cbruni@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70741}
    447915ef
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...