• Clemens Hammacher's avatar
    [wasm] [interpreter] Ignore stack effects after unreachable · 4423c9cc
    Clemens Hammacher authored
    During computation of the side table, ignore stack effects of
    instructions following any unconditional jump in the same block
    (|unreachable|, |br|, |br_table| or |return| jump out of the block).
    Without this fix, the current stack height might underflow, or we compute an
    unnecessarily large max_stack_height_. Note that those instruction will
    never get executed anyway.
    Hence, we don't need to store any side table information for such
    unreachable code.
    
    R=rossberg@chromium.org
    BUG=chromium:716936, chromium:715990
    
    Change-Id: I282f7f18ba1b972a112210e692f6cd05cf32308c
    Reviewed-on: https://chromium-review.googlesource.com/493266Reviewed-by: 's avatarAndreas Rossberg <rossberg@chromium.org>
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45059}
    4423c9cc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...