• Tobias Tebbi's avatar
    Revert "[torque] introduce JSAny type for user-accessible JavaScript values" · 4418a7b9
    Tobias Tebbi authored
    This reverts commit 79b00555.
    
    Reason for revert: needs more discussion
    
    Original change's description:
    > [torque] introduce JSAny type for user-accessible JavaScript values
    > 
    > This CL introduces a JSAny type for user-exposed JavaScript values and
    > a few new types to define it. Especially, it splits Symbol into
    > PrivateSymbol (not exposed) and PublicSymbol (JavaScript exposed
    > symbols).
    > 
    > The change is mostly mechanical, but a few things are interesting:
    > - PropertyKey and JSPrimitive were designed to coincide with the spec
    >   notions of IsPropertyKey() and primitive value, respectively.
    > - Since Name is an open type, we define AnyName to be the known
    >   subtypes of Name. This is not too elegant, but by using AnyName
    >   instead of Name, typeswitch can properly conclude something if a
    >   subtype of Name is excluded.
    > 
    > Small drive-by changes, which were necessary:
    > - Allow subtyping on label parameters.
    > - Fix the formatting of typeswitch, it was broken with union types
    >   in case types.
    > 
    > Bug: v8:7793
    > Change-Id: I14b10507f8cf316ad85e048fe8d53d1df5e0bb13
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1735322
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Reviewed-by: Jakob Gruber <jgruber@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63114}
    
    TBR=neis@chromium.org,jgruber@chromium.org,tebbi@chromium.org
    
    Change-Id: Ifde7881d74afe407628f40047997339d54cb2424
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7793
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1741652Reviewed-by: 's avatarTobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63115}
    4418a7b9
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...