• Santiago Aboy Solanes's avatar
    [turbolizer] Solve off-by-one source position error for non-Wasm · 433ff6b9
    Santiago Aboy Solanes authored
    Wasm has the attribute sourceLineToBytecodePosition and adds the source
    lines via setSourceLineToBytecodePosition in which they are 0-based.
    Non-Wasm doesn't have that attribute and uses insertSourcePositions
    which is 1-based. In non-wasm we are being off by one.
    As a note, the sourcePositionsInRange call in insertSourcePositions
    doesn't return a list for Wasm since they rely on
    setSourceLineToBytecodePosition and therefore do not have that
    off-by-one error.
    
    Drive-by: Several elements have the same source position so update
    addHtmlElementToSourcePosition to handle more than one element.
    
    Drive-by: Renames due to having the same name but different
    capitalization, which was confusing.
    
    Bug: v8:7327
    Change-Id: Ie8a066ca629054a5f5a754deec0ed1917bed2b33
    Notry: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3008634Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75655}
    433ff6b9
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...