• Dominik Inführ's avatar
    [logging] Make Logger::SetUp and TearDownAndGetLogFile thread-safe · 433b4984
    Dominik Inführ authored
    While so far this should only happen in tests in test-log.cc, it can
    happen that background threads using Logger::is_logging() race with
    Logger::TearDownAndGetLogFile().
    
    Fix the race by protecting is_logging_ with the mutex that is also used
    for writing log messages. Logger::is_logging_ now becomes relaxed
    atomic, such that code for logging isn't required to lock the mutex
    to check whether logging is enabled.
    
    Also remove Log::IsEnabled() in favor of Logger::is_logging() to avoid
    checking both flags since both are the same.
    
    Bug: v8:10315
    Change-Id: Ic14e7f74334eb8a8438abad82ad227d1e6752bb8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416488
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69973}
    433b4984
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...