• Dominik Inführ's avatar
    [logging] Make Logger::SetUp and TearDownAndGetLogFile thread-safe · 433b4984
    Dominik Inführ authored
    While so far this should only happen in tests in test-log.cc, it can
    happen that background threads using Logger::is_logging() race with
    Logger::TearDownAndGetLogFile().
    
    Fix the race by protecting is_logging_ with the mutex that is also used
    for writing log messages. Logger::is_logging_ now becomes relaxed
    atomic, such that code for logging isn't required to lock the mutex
    to check whether logging is enabled.
    
    Also remove Log::IsEnabled() in favor of Logger::is_logging() to avoid
    checking both flags since both are the same.
    
    Bug: v8:10315
    Change-Id: Ic14e7f74334eb8a8438abad82ad227d1e6752bb8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2416488
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69973}
    433b4984
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...