• Adam Klein's avatar
    Revert "[builtins] Move most WeakMap/WeakSet code from JS to C++ builtins" · 431abca0
    Adam Klein authored
    This reverts commit 8196e102.
    
    Reason for revert: Performance regression due to hashcode lookup.
    
    Original change's description:
    > [builtins] Move most WeakMap/WeakSet code from JS to C++ builtins
    > 
    > They were already implemented mostly in C++ (only error/negative
    > cases were handled in script), so this is mostly just a cleanup.
    > Only the constructors remain in script after this CL.
    > 
    > Bug: v8:6354
    > Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    > Change-Id: I5b3579337a8e33dc30d49c2da5cfd42baec697bb
    > Reviewed-on: https://chromium-review.googlesource.com/531670
    > Reviewed-by: Camillo Bruni <cbruni@chromium.org>
    > Reviewed-by: Sathya Gunasekaran <gsathya@chromium.org>
    > Commit-Queue: Adam Klein <adamk@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#45924}
    
    TBR=adamk@chromium.org,cbruni@chromium.org,gsathya@chromium.org
    Bug: v8:6354, chromium:733238
    Cq-Include-Trybots: master.tryserver.chromium.linux:linux_chromium_rel_ng
    
    Change-Id: Ia5a741b9587886298f3ca057f6a6adeba556b8e0
    Reviewed-on: https://chromium-review.googlesource.com/537207Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45966}
    431abca0
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...