• Clemens Backes's avatar
    [API] Use proper C++ methods to implement type checks · 42f2e1fc
    Clemens Backes authored
    The {TYPE_CHECK} macro used an ancient pattern to check for
    assignability, by assigning to a static_casted nullptrs of the
    respective types.
    C++11 introduced standard library helpers to express this more
    naturally. The most direct translation would have been to use
    {std::is_assignable} or {std::is_convertible} on the pointer types, but
    in most cases we can be even more strict and force one type to be a
    proper subtype of the other.
    The only exception is {ReturnValue}, which allows to assign anything if
    it's void.
    
    R=ulan@chromium.org
    
    Bug: v8:10155
    Change-Id: I41c1103e0206514c8700c47a0bf107ad704cfc47
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2093497Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#66695}
    42f2e1fc
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...