• Leszek Swirski's avatar
    [maglev] Prevent register merges clobbering phis · 42ce9bc2
    Leszek Swirski authored
    Register merges participate in the same parallel gap move as phi inputs,
    but their allocation is not aware of the phis' existence (since the
    register merge allocation sees the register state _before_ phi input
    allocation, which is because that's what parallel move requires). This
    means that they might move into a register that is used by a Phi, and
    possibly will clobber its value.
    
    Avoid this by recording what registers phis move values into during code
    gen, and skipping register moves into those registers. Also DCHECK that
    the recorded gap moves can't clobber a target register from a previous
    gap move. Additionally, add printing for register merges (both in
    regalloc tracing and graph printing).
    
    Bug: v8:7700
    Change-Id: I8bd4803a30a894c5654e33fc5657ef3fe6cf7a0b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791062Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Victor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82036}
    42ce9bc2
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
maglev Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sandbox Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
temporal Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...