• Leszek Swirski's avatar
    [maglev] Prevent register merges clobbering phis · 42ce9bc2
    Leszek Swirski authored
    Register merges participate in the same parallel gap move as phi inputs,
    but their allocation is not aware of the phis' existence (since the
    register merge allocation sees the register state _before_ phi input
    allocation, which is because that's what parallel move requires). This
    means that they might move into a register that is used by a Phi, and
    possibly will clobber its value.
    
    Avoid this by recording what registers phis move values into during code
    gen, and skipping register moves into those registers. Also DCHECK that
    the recorded gap moves can't clobber a target register from a previous
    gap move. Additionally, add printing for register merges (both in
    regalloc tracing and graph printing).
    
    Bug: v8:7700
    Change-Id: I8bd4803a30a894c5654e33fc5657ef3fe6cf7a0b
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3791062Reviewed-by: 's avatarVictor Gomes <victorgomes@chromium.org>
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Victor Gomes <victorgomes@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#82036}
    42ce9bc2
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...