• Ben Smith's avatar
    [wasm] Simplify module creation · 425fa3ae
    Ben Smith authored
    This includes WasmEngine::NewNativeModule() and WasmModuleObject::New().
    The intent is to make the various ways of creating a module (sync,
    async, deserialize, import) more similar.
    
    After this change, a NativeModule will always be created before a
    WasmModuleObject. This will make it easier to look up a cached
    NativeModule given its wire bytes.
    
    The following changes are made:
    
    * Use WasmCodeManager::EstimateNativeModuleCodeSize() to find the code
      size estimate by default. A different code size estimate is only used in
      tests.
    * Change CompileJsToWasmWrappers() to allocate a new FixedArray instead of
      assuming the array was created with the correct size. This simplifies
      WasmModuleObject::New(), and matches what CompileToNativeModule()
      does.
    * Remove the WasmModuleObject::New() constructor that creates a
      NativeModule. This case was only used in DeserializeNativeModule() and
      in test code.
    
    Change-Id: I6bdfc425057f92de11abbbf702d052d40aa8267d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1717497
    Commit-Queue: Ben Smith <binji@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#62925}
    425fa3ae
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...