• Frank Emrich's avatar
    [dict-proto] update comment describing layout of ordered hash tables · 4242b192
    Frank Emrich authored
    The comment at the beginning of ordered-hash-table.h desribing the
    layout of ordered hash tables seems to have become outdated.
    
    1. There was a "kPrefixSize + " missing in the description of the left
      bound of the first non-fixed-sized part in normal and obsoleted
      tables.
    
    The following only affects obsoleted tables:
    
    2. The bucket count doesn't reside at [kPrefixSize + 0], instead it is
      unchanged w.r.t normal tables, and resides at [kPrefixSize + 2]
    3. The next newer table takes place of the element count, residing
      at  [kPrefixSize + 0]. This can be seen by NextTableIndex() being
      defined as NumberOfElementsIndex()
    4. The number of removed holes is never written anywhere when
      obsoleting a table. Instead, the number of deleted elements count is
      used for this. This can be see by
      DCHECK_EQ(table->NumberOfDeletedElements(), removed_holes_index);
      in method Rehash
    5. kClearedTableSentinel is written to the number of deleted element
      slot when clearing a table, as seen by
      table->SetNumberOfDeletedElements(kClearedTableSentinel);
      in method Clear
    
    Bug: v8:7569, v8:11074
    Change-Id: I0e6750fc57c90b6c09fc41f001cd555f7c455fd3
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2505763
    Commit-Queue: Frank Emrich <emrich@google.com>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70918}
    4242b192
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...