• Dominik Inführ's avatar
    [logging] Make Log::IsEnabled() atomic · 41d2e5c9
    Dominik Inführ authored
    With concurrent allocation background threads invoke Log::IsEnabled()
    as well. Fix data race here by making is_enabled_ atomic, such that
    IsEnabled() remains cheap.
    
    After locking the mutex in MessageBuilder, IsEnabled() needs to be
    checked again in case an old value was read. Otherwise we might log
    even though logging was already disabled on another thread.
    
    The other direction where a log message isn't logged is deemed
    acceptable.
    
    Bug: v8:10315
    Change-Id: I32c9dd2e9879fbdb4ca94e080a16ddd875de7c30
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2362948
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#69495}
    41d2e5c9
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...