• Clemens Backes's avatar
    [wasm] Be more strict about allowed SIMD opcodes · 40738e6c
    Clemens Backes authored
    This makes some checks a bit stricter to avoid accepting illegal relaxed
    SIMD opcodes.
    
    1) The default case in the Liftoff compiler should be UNREACHABLE,
       such that the switch case is required to cover all defined opcodes.
    2) The {WasmOpcodes::IsRelaxedSimdOpcode} wrongly also returned {true}
       for opcodes like 0xfd300. We should really check nibbles 3-5 for the
       exact value 0xfd1.
    3) {WasmOpcodes::Signature} was returning a non-null signatures for
       illegal opcodes like 0xfd200, because {IsRelaxedSimdOpcode} returned
       false, and then we would just use the lower bytes for the lookup in
       the SIMD signature table.
    
    R=thibaudm@chromium.org
    CC=gdeepti@chromium.org
    
    Bug: chromium:1324081
    Change-Id: Idbfde570ccd782e59b47b96e7ca8cc28fa7fae98
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3687309
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#80934}
    40738e6c
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...