• jfb's avatar
    Revert of [coverage] Filter some files from instrumentation. (patchset #3... · 4014f1c7
    jfb authored
    Revert of [coverage] Filter some files from instrumentation. (patchset #3 id:40001 of https://codereview.chromium.org/1730543002/ )
    
    Reason for revert:
    This breaks `gclient sync` because v8_target_arch isn't defined.
    
    gyp: name 'v8_target_arch' is not defined while evaluating condition
    '(OS=="linux" or OS=="mac") and (target_arch=="ia32" or target_arch=="x64") and
             (v8_target_arch!="x87" and v8_target_arch!="x32") and coverage==0' in
    /media/jfb/ssd/v8/v8/build/all.gyp
    Error: Command '/usr/bin/python v8/build/gyp_v8' returned non-zero exit status 1
    in /media/jfb/ssd/v8
    
    Original issue's description:
    > [coverage] Filter some files from instrumentation.
    >
    > This filters test and third_party files to get a speed-up
    > when running tests and when collecting profile data.
    >
    > BUG=chromium:568949
    > LOG=n
    >
    > Committed: https://crrev.com/761ee31be5ab4fde05c294e5d632608fbaea8ad4
    > Cr-Commit-Position: refs/heads/master@{#34216}
    >
    > Committed: https://crrev.com/906db7448702a6ac9fab2a445c57cc85f6dd1b1a
    > Cr-Commit-Position: refs/heads/master@{#34253}
    
    TBR=tandrii@chromium.org,kjellander@chromium.org,machenbach@chromium.org
    # Skipping CQ checks because original CL landed less than 1 days ago.
    NOPRESUBMIT=true
    NOTREECHECKS=true
    NOTRY=true
    BUG=chromium:568949
    
    Review URL: https://codereview.chromium.org/1737433002
    
    Cr-Commit-Position: refs/heads/master@{#34258}
    4014f1c7
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
docs Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...