• Leszek Swirski's avatar
    [maglev] Remove LiveNodeInfo, store its data directly on ValueNode · 3fd2428c
    Leszek Swirski authored
    LiveNodeInfo was stored in a Node->LiveNodeInfo map, which was never
    copied or merged alongside control flow. Lookups in this map were a bit
    part of register allocation time, and it was mostly duplicating data
    that was already in the ValueNode.
    
    So, instead of a separate LiveNodeInfo, store the current register
    allocation state directly on the ValueNode. This involves a bit of
    clobbering of state (in particular, we have to clobber the next_use id),
    but that doesn't matter since regalloc is a forward pass and with this
    change, it's less memory and zero map lookups.
    
    Measuring on a (very large) function, this reduces compile time from
    300ms to 200ms.
    
    Bug: v8:7700
    Change-Id: I02620f1a795bd308d1de03d694c102cb5ea3ff50
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3500617Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Commit-Queue: Leszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79339}
    3fd2428c
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...