• Zhi An Ng's avatar
    [wasm-simd][ia32][x64] Only use registers for shuffles · 3fb07882
    Zhi An Ng authored
    Shuffles have pattern matching clauses which, depending on the
    instruction used, can require src0 or src1 to be register or not.
    However we do not have 16-byte alignment for SIMD operands yet, so it
    will segfault when we use an SSE SIMD instruction with unaligned
    operands.
    
    This patch fixes all the shuffle cases to always use a register for the
    input nodes, and it does so by ignoring the values of src0_needs_reg and
    src1_needs_reg. When we eventually have memory alignment, we can
    re-enable this check, without mucking around too much in the logic in
    each shuffle match clause.
    
    Bug: v8:9198
    Change-Id: I264e136f017353019f19954c62c88206f7b90656
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2504849Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarAdam Klein <adamk@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#70848}
    3fb07882
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...