• Benedikt Meurer's avatar
    [debug] Hold on to promises weakly from the debugger's promise stack. · 3eb6b7ac
    Benedikt Meurer authored
    The debugger maintains a stack of promises used for catch prediction
    with promise builtins and async functions. Previously this stack would
    hold on to the individual promises strongly, and subtle bugs that lead
    to not properly cleaning up the stack in some corner cases would often
    lead to significant memory issues (e.g. leaking whole iframes).
    
    This refactors the PromiseOnStack to be
    
      (a) on the V8 heap, rather than allocating C++ structs with global
          handles pointing to the promises, and
      (b) hold on to the promises only weakly.
    
    While this will not guarantee proper promise stack management, it will
    at least ensure that edge cases don't lead to catastrophic (debugger
    only) leaks.
    
    Bug: chromium:1292063
    Change-Id: I9c293ca2032de3a59e1e9624f132d37187805567
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3545176
    Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79594}
    3eb6b7ac
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...