• Maya Lekova's avatar
    Revert "[stack-traces] Don't hold on to code objects from StackFrameInfos." · 3ea957a6
    Maya Lekova authored
    This reverts commit 6b1fb003.
    
    Reason for revert: breaks gc stress bots - https://ci.chromium.org/ui/p/v8/builders/ci/V8%20Linux%20-%20gc%20stress/36626/overview
    
    Original change's description:
    > [stack-traces] Don't hold on to code objects from StackFrameInfos.
    >
    > Previously every `StackFrameInfo` instance would maintain a reference to
    > an AbstractCode object, which was used to resolve the `code_offset` on
    > that stack frame. However, it turns out that nowadays this is not
    > necessary anymore, since all `code_offset`s reported for JavaScript
    > frames are already bytecode offsets and thus can be resolved by just
    > looking at the functions' bytecode.
    >
    > For WebAssembly frames we will also eagerly resolve the `code_offset`
    > (which is different depending on whether we're looking at Liftoff or
    > TurboFan code) to the byte offset (relative to the function start) and
    > stash that away in the `StackFrameInfo`.
    >
    > For builtin exit frames, the `abstract_code` on the function always
    > refers to the builtin code object and thus, there's no point in keeping
    > an extra pointer to it around on the `StackFrameInfo`.
    >
    > This way the `StackFrameInfo` representation is somewhat uniform, and
    > more importantly, the `StackFrameInfo` instances will no longer need to
    > hold to concrete code objects.
    >
    > Drive-by-fix: Use `FixedArray::SetAndGrow()` when adding to the elements
    > in the `StackTraceBuilder`.
    >
    > Also-By: szuend@chromium.org, jarin@chromium.org
    > Bug: chromium:1258599, chromium:1077657, v8:8742, chromium:1069425
    > Change-Id: I650e400e0e1acd920281669bdc7b5e1199683ae8
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3323073
    > Reviewed-by: Jakob Kummerow <jkummerow@chromium.org>
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Benedikt Meurer <bmeurer@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#78320}
    
    Bug: chromium:1258599, chromium:1077657, v8:8742, chromium:1069425
    Change-Id: I20643ad8f0c383b754841fc52f9b3447b004c9d0
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3327141
    Auto-Submit: Maya Lekova <mslekova@chromium.org>
    Owners-Override: Maya Lekova <mslekova@chromium.org>
    Commit-Queue: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
    Cr-Commit-Position: refs/heads/main@{#78323}
    3ea957a6
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...