• Georg Neis's avatar
    Reland "[parsing] inline ArrayLiteral creation for spread calls" · 82345e9f
    Georg Neis authored
    This reverts commit f48e7349.
    
    Reason for revert: innocent!!
    
    Original change's description:
    > Revert "[parsing] inline ArrayLiteral creation for spread calls"
    > 
    > This reverts commit 93fc3841.
    > 
    > Reason for revert: may break node.js integration
    > 
    > Original change's description:
    > > [parsing] inline ArrayLiteral creation for spread calls
    > > 
    > > Instead of using runtime calls to generate the Array Literal passed to
    > > %reflect_call / %reflect_construct, we create an ArrayLiteral from the
    > > list of arguments, and perform spreads using the interpreter mechanism for
    > > spreading in ArrayLiterals (thus, the spreading becomes inline). This
    > > array literal is still passed to %reflect_call / %reflect_construct as
    > > before.
    > > 
    > > This cuts the runtime for bench-spread-call.js -> testSpread roughly in
    > > half, and will likely improve further once
    > > https://chromium-review.googlesource.com/c/v8/v8/+/915364 has landed.
    > > 
    > > BUG=v8:7446
    > > R=​neis@chromium.org, adamk@chromium.org
    > > 
    > > Change-Id: I74a6acd3a60aad422e4ac575275c7b567659d8ad
    > > Reviewed-on: https://chromium-review.googlesource.com/939587
    > > Commit-Queue: Georg Neis <neis@chromium.org>
    > > Reviewed-by: Georg Neis <neis@chromium.org>
    > > Reviewed-by: Benedikt Meurer <bmeurer@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#51678}
    > 
    > TBR=adamk@chromium.org,neis@chromium.org,caitp@igalia.com,bmeurer@chromium.org
    > 
    > Change-Id: I4730077591bce0e5e7b2ce7d59678e8b7135cc08
    > No-Presubmit: true
    > No-Tree-Checks: true
    > No-Try: true
    > Bug: v8:7446
    > Reviewed-on: https://chromium-review.googlesource.com/945769
    > Reviewed-by: Sigurd Schneider <sigurds@chromium.org>
    > Commit-Queue: Sigurd Schneider <sigurds@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#51682}
    
    TBR=adamk@chromium.org,neis@chromium.org,sigurds@chromium.org,caitp@igalia.com,bmeurer@chromium.org
    
    Change-Id: I977513bea06a4f3fba03fa4a89270298475422e2
    No-Presubmit: true
    No-Tree-Checks: true
    No-Try: true
    Bug: v8:7446
    Reviewed-on: https://chromium-review.googlesource.com/945808Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Georg Neis <neis@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#51686}
    82345e9f
Name
Last commit
Last update
..
c-signature.h Loading commit data...
call-tester.h Loading commit data...
code-assembler-tester.h Loading commit data...
codegen-tester.cc Loading commit data...
codegen-tester.h Loading commit data...
function-tester.cc Loading commit data...
function-tester.h Loading commit data...
graph-builder-tester.h Loading commit data...
test-basic-block-profiler.cc Loading commit data...
test-branch-combine.cc Loading commit data...
test-code-assembler.cc Loading commit data...
test-code-generator.cc Loading commit data...
test-gap-resolver.cc Loading commit data...
test-graph-visualizer.cc Loading commit data...
test-instruction.cc Loading commit data...
test-js-constant-cache.cc Loading commit data...
test-js-context-specialization.cc Loading commit data...
test-js-typed-lowering.cc Loading commit data...
test-jump-threading.cc Loading commit data...
test-linkage.cc Loading commit data...
test-loop-analysis.cc Loading commit data...
test-machine-operator-reducer.cc Loading commit data...
test-multiple-return.cc Loading commit data...
test-node.cc Loading commit data...
test-operator.cc Loading commit data...
test-representation-change.cc Loading commit data...
test-run-bytecode-graph-builder.cc Loading commit data...
test-run-calls-to-external-references.cc Loading commit data...
test-run-deopt.cc Loading commit data...
test-run-intrinsics.cc Loading commit data...
test-run-jsbranches.cc Loading commit data...
test-run-jscalls.cc Loading commit data...
test-run-jsexceptions.cc Loading commit data...
test-run-jsobjects.cc Loading commit data...
test-run-jsops.cc Loading commit data...
test-run-load-store.cc Loading commit data...
test-run-machops.cc Loading commit data...
test-run-native-calls.cc Loading commit data...
test-run-retpoline.cc Loading commit data...
test-run-stackcheck.cc Loading commit data...
test-run-stubs.cc Loading commit data...
test-run-tail-calls.cc Loading commit data...
test-run-unwinding-info.cc Loading commit data...
test-run-variables.cc Loading commit data...
test-run-wasm-machops.cc Loading commit data...
value-helper.cc Loading commit data...
value-helper.h Loading commit data...