• Leszek Swirski's avatar
    [scanner] Make position a parameter of ReadBlock · 3e9ba672
    Leszek Swirski authored
    It's not obvious for Utf16CharacterStream::ReadBlock that the block it
    has to read is implicitly the one at the current pos(), and it was
    slightly odd how ReadBlockAt had to fiddle with buffer_* values to make
    pos() return the desired value before ReadBlock is called -- especially
    since ReadBlock would usually overwrite those changes.
    
    Instead, we can just make ReadBlock take an explicit position, and get
    rid of ReadBlockAt entirely.
    
    As a drive-by, I was always confused by what the various buffer_*
    actually mean (especially the difference between buffer_cursor_ and
    buffer_pos_) so document them with some ASCII art.
    
    Change-Id: I610019089920692f54e01ae979c0ba827779e414
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3217194
    Auto-Submit: Leszek Swirski <leszeks@chromium.org>
    Commit-Queue: Toon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77315}
    3e9ba672
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...