• Clemens Backes's avatar
    [wasm] Fix check failure on low reservation limits · 3cd74b65
    Clemens Backes authored
    If fuzzers pass a low --wasm-max-initial-code-space-reservation limit,
    we might run into a DCHECK/CHECK failure because the "overhead" per code
    space (for jump tables) is more than half of the reserved code space
    (DCHECK) or actually bigger than the reserved code space (CHECK).
    
    This CL fixes that by explicitly failing with an OOM message in that
    case. This should only happen if that testing flag is set.
    
    I do have a test case for this (reduced from the ClusterFuzz report) but
    it needs >20000 functions (to make the jump tables big enough to fail
    the checks), so it runs really slow (>90 seconds in debug).
    Since the failure only happens with a testing flag, I think it's
    acceptable to fix this without a regression test.
    
    R=ahaas@chromium.org
    
    Bug: chromium:1208259
    Change-Id: I99e56a533efcdfa51d99eb5f64edead490398b3c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2904206Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74666}
    3cd74b65
Name
Last commit
Last update
.github Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...