• pthier's avatar
    Reland "[strings] Fix raw hash lookup for forwarded strings" · 3cb7a814
    pthier authored
    This is a reland of commit 0a1f0e33
    
    Changes since revert:
    - Deferred label for loading from forwarding table.
    - Check if hash is computed instead of checking if it is a forwarding index.
    - Retreive hash from forwarding table only if hash is assumed to be computed.
    
    Original change's description:
    > [strings] Fix raw hash lookup for forwarded strings
    >
    > Raw hashes may need to be looked up via the forwarding table when
    > internalized strings are forwarded to external resources. Notably, the
    > megamorphic ICs were not correctly fetching the raw hash.
    >
    > Bug: v8:12007
    > Change-Id: Ibbc75de57e707788f544fbd1a0f8f0041350e29d
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3885379
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Shu-yu Guo <syg@chromium.org>
    > Reviewed-by: Patrick Thier <pthier@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#83115}
    
    Bug: v8:12007
    Change-Id: Ia88ed51a49c62170bc960b8f69673bb1e59a6009
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3888057
    Commit-Queue: Patrick Thier <pthier@chromium.org>
    Reviewed-by: 's avatarLeszek Swirski <leszeks@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#83246}
    3cb7a814
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...