• Clemens Hammacher's avatar
    Make CallInterfaceDescriptor isolate-independent · 3cb376dc
    Clemens Hammacher authored
    Currently each isolate stores its own array of
    {CallInterfaceDescriptorData}. This array has size 173, and each entry
    has 40 bytes. That's already 7kB per isolate.
    Additionally, each {CallInterfaceDescriptorData} allocates two
    heap-allocated arrays, which probably add up to more than the static
    size of the {CallInterfaceDescriptorData}. Note that all the
    {CallInterfaceDescriptorData} instances are initialized eagerly on
    isolate creation.
    
    Since {CallInterfaceDescriptor} is totally isolate independent itself,
    this CL refactors the current design to avoid a copy of them per
    isolate, and instead shares them process-wide. Still, we need to free
    the allocated heap arrays when the last isolate dies to avoid leaks.
    This can probably be refactored later by statically initializing more
    and avoiding the heap allocations all together.
    
    This refactoring will also allow us to use {CallInterfaceDescriptor}s
    from wasm background compilation threads, which are not bound to any
    isolate.
    
    R=mstarzinger@chromium.org, titzer@chromium.org
    
    Bug: v8:6600
    Change-Id: If8625b89951eec8fa8986b49a5c166e874a72494
    Reviewed-on: https://chromium-review.googlesource.com/1100879
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#53803}
    3cb376dc
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...