• Clemens Backes's avatar
    [wasm] Prevent breakpoints on nonbreakable positions · 3c98a2a3
    Clemens Backes authored
    If a breakpoint is set on a non-breakable position, the wasm interpreter
    just stores the value 0xFF (kInternalBreakpoint) in the function body
    (actually, a copy of the function body). This might overwrite immediates
    and cause subsequent failures in the wasm interpreter.
    
    In JavaScript, breakpoints are just forwarded to the next breakable
    position. This CL implements the same for WebAssembly.
    A cctest tests this behavior, and the existing
    wasm-stepping-byte-offsets.js inspector test is extended to also set the
    breakpoint within an i32 constant immediate.
    
    R=leese@chromium.org, mstarzinger@chromium.org
    CC=​bmeurer@chromium.org
    
    Bug: chromium:1025184
    Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65070}
    3c98a2a3
Name
Last commit
Last update
..
benchmarks Loading commit data...
cctest Loading commit data...
common Loading commit data...
debugger Loading commit data...
fuzzer Loading commit data...
inspector Loading commit data...
intl Loading commit data...
js-perf-test Loading commit data...
memory Loading commit data...
message Loading commit data...
mjsunit Loading commit data...
mkgrokdump Loading commit data...
mozilla Loading commit data...
test262 Loading commit data...
torque Loading commit data...
unittests Loading commit data...
wasm-api-tests Loading commit data...
wasm-js Loading commit data...
wasm-spec-tests Loading commit data...
webkit Loading commit data...
BUILD.gn Loading commit data...
OWNERS Loading commit data...