• Clemens Backes's avatar
    [wasm] Prevent breakpoints on nonbreakable positions · 3c98a2a3
    Clemens Backes authored
    If a breakpoint is set on a non-breakable position, the wasm interpreter
    just stores the value 0xFF (kInternalBreakpoint) in the function body
    (actually, a copy of the function body). This might overwrite immediates
    and cause subsequent failures in the wasm interpreter.
    
    In JavaScript, breakpoints are just forwarded to the next breakable
    position. This CL implements the same for WebAssembly.
    A cctest tests this behavior, and the existing
    wasm-stepping-byte-offsets.js inspector test is extended to also set the
    breakpoint within an i32 constant immediate.
    
    R=leese@chromium.org, mstarzinger@chromium.org
    CC=​bmeurer@chromium.org
    
    Bug: chromium:1025184
    Change-Id: Ia2706f8f1c3d686cbbe8e1e7339d9ee86247bb4a
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1925152
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarBenedikt Meurer <bmeurer@chromium.org>
    Reviewed-by: 's avatarMichael Starzinger <mstarzinger@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65070}
    3c98a2a3
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...