• Jakob Gruber's avatar
    [snapshot] Clear reconstructable data prior to d8 stress_snapshot run · 3c422d1c
    Jakob Gruber authored
    The serializer currently cannot handle a heap state containing
    arbitrary compiled Code objects. As a quick fix for the
    --stress-snapshot d8 flag, we clear compiled data from the isolate
    prior to the serialize-deserialize-verify pass.
    
    With this change, mjsunit tests pass on x64.
    
    The %SerializeDeserializeNow() runtime function would require more
    work, since it is not possible to mutate the heap to this extent while
    still preserving a runnable host context and isolate. We will need
    another solution there.
    
    Drive-by: Skip the stress_snapshot variant except for the mjsunit
    suite.
    
    Tbr: machenbach@chromium.org
    Bug: v8:10493,v8:10416
    Change-Id: Ie110da8b51613fcd69c7f391d3cf8589d6b04dd8
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2182429Reviewed-by: 's avatarJakob Gruber <jgruber@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Commit-Queue: Jakob Gruber <jgruber@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67585}
    3c422d1c
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...