• Seth Brenith's avatar
    [debug] Don't crash when breaking on entry to functions with heap vars · 3c20dfed
    Seth Brenith authored
    Any function with heap-allocated variables starts by creating and
    pushing a new context for its execution. When entering the debugger due
    to the stack check in the beginning of InterpreterEntryTrampoline, the
    function has not yet had a chance to push that new context. The code in
    ScopeIterator currently assumes that any function which needs a context
    already has one by the time the debugger attempts to iterate scopes, but
    in this case that assumption is invalid, which can cause a null deref.
    
    This change introduces a new function ScopeIterator::NeedsAndHasContext
    to replace previous calls to current_scope_->NeedsContext(). This new
    function checks for the case where the current scope matches the closure
    scope but the context matches the containing context for the function,
    which implies that the function has not yet pushed its own context.
    
    Bug: v8:10319, chromium:1038747
    Change-Id: I29636f269c44d35b68d8446769d17170eed50e89
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2168021
    Commit-Queue: Seth Brenith <seth.brenith@microsoft.com>
    Reviewed-by: 's avatarSimon Zünd <szuend@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#67519}
    3c20dfed
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
OWNERS Loading commit data...