• adamk's avatar
    Don't skip hole checks inside patterns in parameter lists · 3c39bac4
    adamk authored
    Previously, b6e9f625 fixed self-assignment
    in parameters to throw. But it failed to deal with the case of
    destructuring with defaults. This patch extends that previous approach
    to always treat the end of a parameter as its initializer position,
    whether it has an initializer or not.
    
    This is the minimal change to make it easy to merge; a follow-up
    will rename the field of Parameter from "initializer_end_position"
    to "end_position".
    
    BUG=v8:5454
    
    Review-Url: https://codereview.chromium.org/2390943002
    Cr-Commit-Position: refs/heads/master@{#39962}
    3c39bac4
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...