• Jaime Bernardo's avatar
    [build] Set MSVS .obj folders in gyp for v8_base · 3bef2af6
    Jaime Bernardo authored
    Building on Windows with gyp fails depending on the result from
    sharding the src/v8.gyp:v8_base target. If two source files with the
    same name are in the same shard, their output object file path would
    conflict with one another. One example of this conflict is v8_base's
    runtime/runtime.cc and the V8 inspector's protocol/Runtime.cpp that
    is generated at build time, for which the files runtime.obj and
    Runtime.obj would be created, but MSVS overwrites one of them with
    the other.
    
    Dividing the .obj output path by the original source's extension
    prevents this overwrite.
    
    Refs: https://github.com/nodejs/node/pull/13959
    Bug: 
    Change-Id: I158e6178f2511297899ee50ea159f574916f903f
    Reviewed-on: https://chromium-review.googlesource.com/556599Reviewed-by: 's avatarMichael Achenbach <machenbach@chromium.org>
    Commit-Queue: Michael Achenbach <machenbach@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#46354}
    3bef2af6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...