• Sathya Gunasekaran's avatar
    Revert "[ic] Fix KeyedLoadIC for ArrayIndex access" · 3bd0dc18
    Sathya Gunasekaran authored
    This reverts commit 5c59ba4f.
    
    Reason for revert: requires more thinking 
    
    Original change's description:
    > [ic] Fix KeyedLoadIC for ArrayIndex access
    > 
    > Previously, without support for converting strings to numbers we'd
    > switch to megamorphic state and go to the runtime always to do the
    > conversion causing a performance cliff.
    > 
    > This patch improves the following js-perf-test scores:
    > Object-Lookup-String-Constant-BytecodeHandler: 4.25%
    > Object-Lookup-Index-String-BytecodeHandler: 5.41%
    > 
    > Bug: v8:9449
    > Change-Id: I63787fa84373fc946f1304b0141e48a52a1b4bcb
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1690953
    > Reviewed-by: Igor Sheludko <ishell@chromium.org>
    > Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63293}
    
    TBR=mythria@chromium.org,jyan@ca.ibm.com,gsathya@chromium.org,leszeks@chromium.org,ishell@chromium.org,verwaest@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:9449
    Change-Id: I6b6ad5901175c2e6bbd7516b13e91471adb5776d
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1765532Reviewed-by: 's avatarSathya Gunasekaran  <gsathya@chromium.org>
    Commit-Queue: Sathya Gunasekaran  <gsathya@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63347}
    3bd0dc18
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...