• Clemens Hammacher's avatar
    Reland^2 "Remove all custom CopyCharsUnsigned implementations" · 3b808dee
    Clemens Hammacher authored
    This is an unmodified reland of
    9febc505. Nosnap bots do not block
    LKGR any more: https://crbug.com/v8/9737#c10.
    
    Original change's description:
    > Reland "Remove all custom CopyCharsUnsigned implementations"
    >
    > This is a reland of 5d8c4890
    >
    > Original change's description:
    > > Remove all custom CopyCharsUnsigned implementations
    > >
    > > It's unclear whether the custom implementation have any advantage over
    > > the standard library one's.
    > > Since we update our toolchain and standard library regularly, it might
    > > well be the case that the custom implementations are slower by now.
    > >
    > > Thus this CL removes all {CopyCharsUnsigned} implementations and
    > > implements {CopyChars} generically using {std::copy_n}.
    > >
    > > Note that this does not touch the {MemMove} and {MemCopy} functions
    > > yet, as we have seen regressions when trying to remove them before
    > > (https://crbug.com/v8/8675#c5).
    > >
    > > R=leszeks@chromium.org
    > >
    > > Bug: v8:9396
    > > Change-Id: I97a183afebcccd2fbb567bdba02e827331475608
    > > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1800577
    > > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > > Cr-Commit-Position: refs/heads/master@{#63808}
    >
    > Bug: v8:9396
    > Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng
    > Change-Id: I9cd754ebe6b802bb4aabd6d2a448de41da040874
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1807357
    > Reviewed-by: Leszek Swirski <leszeks@chromium.org>
    > Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63823}
    
    TBR=leszeks@chromium.org
    
    Bug: v8:9396
    Change-Id: I793524d76b8b9c93d2a98c73e8d72967880fe1cf
    Cq-Include-Trybots: luci.v8.try:v8_linux64_ubsan_rel_ng
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1809362
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarClemens Hammacher <clemensh@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63857}
    3b808dee
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...