• Mythri A's avatar
    Reland "[sparkplug] Support bytecode / baseline code flushing with sparkplug" · 3ae733f9
    Mythri A authored
    This is a reland of ea55438a. Relanding
    after a fix lands here:
    https://chromium-review.googlesource.com/c/v8/v8/+/3030711. The failures
    were caused because baseline code could be flushed during the process
    of deoptimization after we choose which entry (InterpreterEnterAt* /
    BaselineEnterAt* ) builtin to use. BaselineEnterAt* builtins expect
    baseline code but it could be flushed before we execute the builtin. The
    fix is to defer the decision.
    
    Original change's description:
    > [sparkplug] Support bytecode / baseline code flushing with sparkplug
    >
    > Currently with sparkplug we don't flush bytecode / baseline code of
    > functions that were tiered up to sparkplug. This CL adds the support to
    > flush baseline code / bytecode of functions that have baseline code too.
    > This CL:
    > 1. Updates the BodyDescriptor of JSFunction to treat the Code field of
    > JSFunction as a custom weak pointer where the code is treated as weak if
    > the bytecode corresponding to this function is old.
    > 2. Updates GC to handle the functions that had a weak code object during
    > the atomic phase of GC.
    > 3. Updates the check for old bytecode to also consider when there is
    > baseline code on the function.
    >
    > This CL doesn't change any heuristics for flushing. The baseline code
    > will be flushed at the same time as bytecode.
    >
    > Change-Id: I6b51e06ebadb917b9f4b0f43f2afebd7f64cd26a
    > Bug: v8:11947
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2992715
    > Commit-Queue: Mythri Alle <mythria@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Reviewed-by: Toon Verwaest <verwaest@chromium.org>
    > Reviewed-by: Dominik Inführ <dinfuehr@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#75674}
    
    Bug: v8:11947
    Change-Id: I63dce4cd9f6271c54049cc09f95d12e2795f15d1
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3035774Reviewed-by: 's avatarDominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarAndreas Haas <ahaas@chromium.org>
    Reviewed-by: 's avatarToon Verwaest <verwaest@chromium.org>
    Reviewed-by: 's avatarRoss McIlroy <rmcilroy@chromium.org>
    Commit-Queue: Mythri Alle <mythria@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#75810}
    3ae733f9
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...