• Maya Lekova's avatar
    Revert "[CSA][cleanup] TNodify some methods related to prototype and property lookup" · 3a7a4a2f
    Maya Lekova authored
    This reverts commit 82111e22.
    
    Reason for revert: Speculative revert, could be causing timeouts - https://ci.chromium.org/p/v8/builders/ci/V8%20Linux%20-%20arm%20-%20sim%20-%20debug/17567
    
    Original change's description:
    > [CSA][cleanup] TNodify some methods related to prototype and property lookup
    > 
    > This is a CL in a string of CLs that aims to TNodify CSA. In particular,
    > there were some loads that were done in AnyTagged instead of
    > TaggedPointer. TNode-ifying them brings improvement in pointer
    > compression since we are able to decompress using the Pointer
    > decompression.
    > 
    > TNodified:
    >  * LoadJSFunctionPrototype
    >  * TryPrototypeChainLookup
    >  * OrdinaryHasInstance
    > 
    > Also TNodified loads regarding:
    >  * FeedbackCell::kValueOffset
    >  * HeapObject::kMapOffset
    >  * JSFunction::kSharedFunctionInfoOffset
    >  * JSFunction::kFeedbackCellOffset
    >  * Map::kInstanceTypeOffset
    >  * Map::kInstanceDescriptorsOffset
    >  * Map::kPrototypeOffset
    > 
    > Drive-by cleanup: StoreJSArrayLength and StoreElements were unused.
    > 
    > Bug: v8:6949, v8:9396
    > Change-Id: I89697b5c02490906be1eee63cf3d9e60a1094d48
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1755844
    > Commit-Queue: Santiago Aboy Solanes <solanes@chromium.org>
    > Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#63216}
    
    TBR=rmcilroy@chromium.org,solanes@chromium.org
    
    # Not skipping CQ checks because original CL landed > 1 day ago.
    
    Bug: v8:6949, v8:9396
    Change-Id: Ib6ae8fe86a598ed1066894595565e1162cf7dd1f
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1758310Reviewed-by: 's avatarMaya Lekova <mslekova@chromium.org>
    Reviewed-by: 's avatarSantiago Aboy Solanes <solanes@chromium.org>
    Commit-Queue: Maya Lekova <mslekova@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#63233}
    3a7a4a2f
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...