• Anton Bikineev's avatar
    cppgc: young-gen: Always execute custom weak callbacks for old objects · 3984ddc0
    Anton Bikineev authored
    Custom callbacks assume that untraced pointers always point to valid,
    not freed objects. They must make sure that upon callback completion no
    UntracedMembers point to an unreachable object. This may not hold true
    if a custom callback for an old object operates with a reference to a
    young object that was freed on a minor collection cycle. To maintain
    the mentioned invariant, the CL calls custom callbacks for old objects
    on every minor collection cycle.
    
    The alternative options could be:
    1) Replacing all UntracedMembers with WeakMembers, since WeakMember
       supports tracing and the barrier.
    2) Emitting the generational barrier for UntracedMember + tracing
       UntracedMember on minor collection cycles.
    The first option requires changing multiple use sites and can bring some
    performance regression. The second option requires changing the GC logic
    and the semantics of UntracedMember.
    
    Bug: chromium:1029379
    Change-Id: I9bb89e4787daf05990feed374dceca940be7be63
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3472499Reviewed-by: 's avatarMichael Lippautz <mlippautz@chromium.org>
    Commit-Queue: Anton Bikineev <bikineev@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#79221}
    3984ddc0
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.style.yapf Loading commit data...
.vpython Loading commit data...
.vpython3 Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...