• Tobias Tebbi's avatar
    Reland "[turbofan] extend type asserts to cover all JS types" · 392078fb
    Tobias Tebbi authored
    This is a reland of 45227ffd
    Differences:
    - Handle one more flags conflict in variants.py.
    - Disallow %VerifyType without --concurrent-recompilation.
    
    Original change's description:
    > [turbofan] extend type asserts to cover all JS types
    >
    > Extend type assertions to all types covering JavaScript values.
    > This is achieved by allocating type representations on the heap using
    > newly defined HeapObject subclasses. To allocate these in the compiler,
    > we disable concurrent compilation for the --assert-types flag for now.
    >
    > Fix two type errors that came up with the existing tests:
    > 1. JSCreateKeyValueArray has type Array (i.e., a JSArray) instead of
    >    OtherObject.
    > 2. OperationTyper::NumberToString(Type) can type the result as the
    >    HeapConstant Factory::zero_string(). However, NumberToString does
    >    not always produce this string. To avoid regressions, the CL keeps
    >    the HeapConstant type and changes the runtime and builtin code to
    >    always produce the canonical "0" string.
    >
    > A few tests were failing because they check for truncations to work
    > and prevent deoptimization. However, AssertType nodes destroy all
    > truncations (which is by design), so these tests are incompatible
    > and now disabled for the assert_types variant.
    >
    > Drive-by fix: a few minor Torque issues that came up.
    >
    > Change-Id: If03b7851f7e6803a2f69edead4fa91231998f764
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3234717
    > Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
    > Reviewed-by: Omer Katz <omerkatz@chromium.org>
    > Commit-Queue: Tobias Tebbi <tebbi@chromium.org>
    > Cr-Commit-Position: refs/heads/main@{#77565}
    
    Change-Id: I5b3c6745c6ad349ff8c2b199d9afdf0a9b5a7392
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3247035
    Auto-Submit: Tobias Tebbi <tebbi@chromium.org>
    Commit-Queue: Nico Hartmann <nicohartmann@chromium.org>
    Reviewed-by: 's avatarOmer Katz <omerkatz@chromium.org>
    Reviewed-by: 's avatarNico Hartmann <nicohartmann@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#77596}
    392078fb
Name
Last commit
Last update
.github Loading commit data...
bazel Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.bazelrc Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.mailmap Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.bazel Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LOONG_OWNERS Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
RISCV_OWNERS Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
WORKSPACE Loading commit data...
codereview.settings Loading commit data...