• Dominik Inführ's avatar
    [heap] Check top for null in Heap::IsPendingAllocation · 38dab434
    Dominik Inführ authored
    Our synchronization protocol for top and limit only guarantees that we
    read the new limit in case we read the new top. However, it could happen
    that we read the old top but the new limit. In the allocation slow path
    we reset both top and limit to 0 first and then reset it to the
    free list allocation boundaries.
    
    With --no-inline-new we are changing top/limit a lot, so it could happen
    that we read the old value for top (0) but a regular address for limit.
    In such cases large parts of the heap would be incorrectly considered
    pending. Handle these cases here by checking that top is non-zero.
    
    This is temporary fix, we believe that it is at least theoretically
    possible to read non-0 but non-consistent values for top/limit as well.
    This will be addressed in a subsequent CL.
    
    Bug: v8:11778
    Change-Id: I6b581f2a6df3f24c16443717b0cde9a18c5f3f40
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2903155
    Commit-Queue: Dominik Inführ <dinfuehr@chromium.org>
    Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#74655}
    38dab434
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...