• Clemens Hammacher's avatar
    [base] Fix CHECK/DCHECK macros for enum types · 38b586c6
    Clemens Hammacher authored
    The problem with enums is that neither is_integral, nor is_signed or
    is_unsigned is true for them. Thus, comparison with our CHECK/DCHECK
    macros always just uses the default comparison, which fails if the
    signedness of the underlying integer types does not match.
    This CL fixes this by considering the underlying integer type of an
    enum to choose the right comparison operator.
    
    R=ishell@chromium.org
    CC=ahaas@chromium.org
    
    Change-Id: I5ef56d1b86228e879f5866967ab7e709f1e97f0b
    Reviewed-on: https://chromium-review.googlesource.com/518123
    Commit-Queue: Clemens Hammacher <clemensh@chromium.org>
    Reviewed-by: 's avatarIgor Sheludko <ishell@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#45593}
    38b586c6
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
docs Loading commit data...
gni Loading commit data...
gypfiles Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...