• Manos Koukoutos's avatar
    [wasm] Rework CALL_INTERFACE macros in WasmDecoder · 389eb1f8
    Manos Koukoutos authored
    Main change: Remove CALL_INTERFACE macro. Use
    CALL_INTERFACE_IF_REACHABLE or invoke interface directly instead.
    Reasoning: Interfaces assume the Decoder is in a non-error state,
    therefore CALL_INTERFACE invoked DCHECK(this->ok()). However,
    CALL_INTERFACE (1) was sometimes erroneously called with an error in the
    decoder, especially in cases where the error occurred inside immediate
    argument parsing, (2) was always called in contexts where the current
    control was guaranteed to be reachable. Due to (1) and (2),
    CALL_INTERFACE is equivalent to CALL_INTERFACE_IF_REACHABLE (there are
    a few exceptions where we can call the interface directly).
    
    Additional change:
    - Rename current_code_reachable_ to current_code_reachable_and_ok_
      to make its name reflect its meaning better.
    
    Bug: chromium:1194784
    Change-Id: I52055161a802e6981506b2a8dc8bb8233198aa2c
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2799351
    Commit-Queue: Manos Koukoutos <manoskouk@chromium.org>
    Reviewed-by: 's avatarThibaud Michaud <thibaudm@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#73771}
    389eb1f8
Name
Last commit
Last update
..
api Loading commit data...
asmjs Loading commit data...
ast Loading commit data...
base Loading commit data...
baseline Loading commit data...
bigint Loading commit data...
builtins Loading commit data...
codegen Loading commit data...
common Loading commit data...
compiler Loading commit data...
compiler-dispatcher Loading commit data...
d8 Loading commit data...
date Loading commit data...
debug Loading commit data...
deoptimizer Loading commit data...
diagnostics Loading commit data...
execution Loading commit data...
extensions Loading commit data...
flags Loading commit data...
handles Loading commit data...
heap Loading commit data...
ic Loading commit data...
init Loading commit data...
inspector Loading commit data...
interpreter Loading commit data...
json Loading commit data...
libplatform Loading commit data...
libsampler Loading commit data...
logging Loading commit data...
numbers Loading commit data...
objects Loading commit data...
parsing Loading commit data...
profiler Loading commit data...
protobuf Loading commit data...
regexp Loading commit data...
roots Loading commit data...
runtime Loading commit data...
sanitizer Loading commit data...
snapshot Loading commit data...
strings Loading commit data...
tasks Loading commit data...
third_party Loading commit data...
torque Loading commit data...
tracing Loading commit data...
trap-handler Loading commit data...
utils Loading commit data...
wasm Loading commit data...
web-snapshot Loading commit data...
zone Loading commit data...
DEPS Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...