• yangguo's avatar
    Serialzier: expand string table as last step before deserializing. · 37928334
    yangguo authored
    Not doing so could result in this scenario:
    - We ensure that the string table is large enough. It is.
    - We compile code stubs, which triggers a GC.
    - The GC clears string table entries.
    - This increases the number of deleted entries in the table.
    - When the deserializer hooks up internalized strings into the
      table, we ensure that the table is large enough every time.
    - Due to changed number of deleted entries, the heuristic
      decides to expand the string table.
    - Allocation during deserialization causes assertion to fail.
    
    BUG=chromium:502085
    LOG=N
    
    Review URL: https://codereview.chromium.org/1197633002
    
    Cr-Commit-Position: refs/heads/master@{#29134}
    37928334
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...