• Peter Marshall's avatar
    Reland "[cpu-profiler] Fix a bug which caused a pure virtual function call" · 3767ab39
    Peter Marshall authored
    This is a reland of c92a1dda
    
    Original change's description:
    > [cpu-profiler] Fix a bug which caused a pure virtual function call
    >
    > We need to remove each Sampler from the SamplerManager before we call
    > the Sampler destructor. This is because the signal handler can interrupt
    > the destructor, and call DoSampler(), which calls sampler->SampleStack()
    > on the sampler being destructed, causing general unhappiness and
    > "Pure virtual function called!" crashes.
    >
    > Bug: v8:8346, v8:5193
    > Change-Id: Iaa595a196eab33fb1af31584e9a68fd1ce0a18f6
    > Reviewed-on: https://chromium-review.googlesource.com/c/1293949
    > Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    > Reviewed-by: Alexei Filippov <alph@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#56882}
    
    TBR=yangguo@chromium.org
    
    Bug: v8:8346, v8:5193
    Change-Id: I9878f65c868ff1aed6f3a587cba688c4241bad8c
    Reviewed-on: https://chromium-review.googlesource.com/c/1298893Reviewed-by: 's avatarPeter Marshall <petermarshall@chromium.org>
    Commit-Queue: Peter Marshall <petermarshall@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#56976}
    3767ab39
Name
Last commit
Last update
benchmarks Loading commit data...
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...
snapshot_toolchain.gni Loading commit data...