• yangguo's avatar
    Do not use js builtins object to determine whether a function is a builtin. · 371ad73a
    yangguo authored
    We can use the script type to determine that instead. Script of type
    TYPE_NATIVE are considered builtins, TYPE_NORMAL are not. The only exception
    to this rule is the empty function, for which the script is TYPE_NATIVE
    (observable by the debugger), but should be stringified to "function () {}"
    instead of "function () { [native code] }". For this, I introduce a
    hide_source flag on the script object.
    
    We also use IsBuiltin and IsSubjectToDebugging interchangeably. For debugger,
    we now use the latter, hiding the detail that only non-builtins are debuggable.
    
    R=mstarzinger@chromium.org
    
    Review URL: https://codereview.chromium.org/1292283004
    
    Cr-Commit-Position: refs/heads/master@{#30285}
    371ad73a
Name
Last commit
Last update
benchmarks Loading commit data...
build Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party/binutils Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.gitignore Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
ChangeLog Loading commit data...
DEPS Loading commit data...
LICENSE Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
Makefile Loading commit data...
Makefile.android Loading commit data...
Makefile.nacl Loading commit data...
OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...