• Clemens Backes's avatar
    Revert "[codegen] Remove redundant xorpd instructions" · 36f159b3
    Clemens Backes authored
    This reverts commit c4cf2ea4.
    
    Reason for revert: Seems to cause more regressions than improvement. Let's see what the perf bots say about the revert.
    
    Original change's description:
    > [codegen] Remove redundant xorpd instructions
    > 
    > It seems like they were originally added in https://crrev.com/23654026
    > (Sep 2013) to break dependences in the OOO pipeline. This code pattern
    > was then later copied for other instructions too
    > (https://crrev.com/1424333002).
    > The reason for the xorpd is not mentioned in the code though, and I
    > found no other compiler doing this. So maybe it's obsolete by now, and
    > only increases code size.
    > 
    > Let's remove them and see if we get any performance regressions.
    > 
    > R=​ahaas@chromium.org
    > CC=​yangguo@chromium.org
    > 
    > Change-Id: I0e6d65afa67f0ee286e5b0ba95c91092c5261c8f
    > Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1926427
    > Reviewed-by: Yang Guo <yangguo@chromium.org>
    > Reviewed-by: Andreas Haas <ahaas@chromium.org>
    > Commit-Queue: Clemens Backes <clemensb@chromium.org>
    > Cr-Commit-Position: refs/heads/master@{#65077}
    
    TBR=yangguo@chromium.org,ahaas@chromium.org,clemensb@chromium.org
    
    Bug: chromium:1027876, chromium:1027449
    Change-Id: I533729722e294dbe567222b1c4084df6b864d2ff
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1958053Reviewed-by: 's avatarClemens Backes <clemensb@chromium.org>
    Reviewed-by: 's avatarYang Guo <yangguo@chromium.org>
    Commit-Queue: Clemens Backes <clemensb@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#65388}
    36f159b3
Name
Last commit
Last update
build_overrides Loading commit data...
custom_deps Loading commit data...
docs Loading commit data...
gni Loading commit data...
include Loading commit data...
infra Loading commit data...
samples Loading commit data...
src Loading commit data...
test Loading commit data...
testing Loading commit data...
third_party Loading commit data...
tools Loading commit data...
.clang-format Loading commit data...
.clang-tidy Loading commit data...
.editorconfig Loading commit data...
.flake8 Loading commit data...
.git-blame-ignore-revs Loading commit data...
.gitattributes Loading commit data...
.gitignore Loading commit data...
.gn Loading commit data...
.vpython Loading commit data...
.ycm_extra_conf.py Loading commit data...
AUTHORS Loading commit data...
BUILD.gn Loading commit data...
CODE_OF_CONDUCT.md Loading commit data...
COMMON_OWNERS Loading commit data...
DEPS Loading commit data...
ENG_REVIEW_OWNERS Loading commit data...
INFRA_OWNERS Loading commit data...
INTL_OWNERS Loading commit data...
LICENSE Loading commit data...
LICENSE.fdlibm Loading commit data...
LICENSE.strongtalk Loading commit data...
LICENSE.v8 Loading commit data...
LICENSE.valgrind Loading commit data...
MIPS_OWNERS Loading commit data...
OWNERS Loading commit data...
PPC_OWNERS Loading commit data...
PRESUBMIT.py Loading commit data...
README.md Loading commit data...
S390_OWNERS Loading commit data...
WATCHLISTS Loading commit data...
codereview.settings Loading commit data...