• Pierre Langlois's avatar
    [heap] Do not use V8_LIKELY on FLAG_disable_write_barriers. · 4a89c018
    Pierre Langlois authored
    FLAG_disable_write_barriers is a constexpr so the V8_LIKELY macro isn't
    necessary. Interestingly, it can also cause clang to warn that the code
    is unreachable, whereas without `__builtin_expect()` the compiler
    doesn't mind. See for example:
    
    ```
    constexpr bool kNo = false;
    
    void warns() {
      if (__builtin_expect(kNo, 0)) {
        int a = 42;
      }
    }
    
    void does_not_warn() {
      if (kNo) {
        int a = 42;
      }
    }
    ```
    
    Compiling V8 for arm64 with both `v8_disable_write_barriers = true` and
    `v8_enable_pointer_compression = false` would trigger this warning.
    
    Bug: v8:9533
    Change-Id: Id2ae156d60217007bb9ebf50628e8908e0193d05
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2534811Reviewed-by: 's avatarUlan Degenbaev <ulan@chromium.org>
    Reviewed-by: 's avatarGeorg Neis <neis@chromium.org>
    Commit-Queue: Pierre Langlois <pierre.langlois@arm.com>
    Cr-Commit-Position: refs/heads/master@{#71157}
    4a89c018
Name
Last commit
Last update
..
arm Loading commit data...
arm64 Loading commit data...
ia32 Loading commit data...
mips Loading commit data...
mips64 Loading commit data...
ppc Loading commit data...
s390 Loading commit data...
x64 Loading commit data...
DIR_METADATA Loading commit data...
OWNERS Loading commit data...
code-generator-impl.h Loading commit data...
code-generator.cc Loading commit data...
code-generator.h Loading commit data...
frame-elider.cc Loading commit data...
frame-elider.h Loading commit data...
gap-resolver.cc Loading commit data...
gap-resolver.h Loading commit data...
instruction-codes.h Loading commit data...
instruction-scheduler.cc Loading commit data...
instruction-scheduler.h Loading commit data...
instruction-selector-impl.h Loading commit data...
instruction-selector.cc Loading commit data...
instruction-selector.h Loading commit data...
instruction.cc Loading commit data...
instruction.h Loading commit data...
jump-threading.cc Loading commit data...
jump-threading.h Loading commit data...
mid-tier-register-allocator.cc Loading commit data...
mid-tier-register-allocator.h Loading commit data...
move-optimizer.cc Loading commit data...
move-optimizer.h Loading commit data...
register-allocation.h Loading commit data...
register-allocator-verifier.cc Loading commit data...
register-allocator-verifier.h Loading commit data...
register-allocator.cc Loading commit data...
register-allocator.h Loading commit data...
spill-placer.cc Loading commit data...
spill-placer.h Loading commit data...
unwinding-info-writer.h Loading commit data...